lucene-java-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin A. Burton" <bur...@newsmonster.org>
Subject Re: DocumentWriter, StopFilter should use HashMap... (patch)
Date Tue, 09 Mar 2004 19:00:53 GMT
Doug Cutting wrote:

> Erik Hatcher wrote:
>
>> Well, one issue you didn't consider is changing a public method 
>> signature.  I will make this change, but leave the Hashtable 
>> signature method there.  I suppose we could change the signature to 
>> use a Map instead, but I believe there are some issues with doing 
>> something like this if you do not recompile your own source code 
>> against a new Lucene JAR.... so I will simply provide another 
>> signature too.
>
>
> This would no longer compile with the change Kevin proposes.
>
> To make things back-compatible we must:
>
> 1. Keep but deprectate StopFilter(Hashtable) constructor;
> 2. Keep but deprecate StopFilter.makeStopTable(String[]);
> 3. Add a new constructor: StopFilter(HashMap);
> 4. Add a new method: StopFilter.makeStopMap(String[]);
>
> Does that make sense?
>
This patch and attachment take care of this problem... 

It does make this class more complex than it needs to be... but 1/2 of 
the methods are deprecated.

Kevin

-- 

Please reply using PGP:

    http://peerfear.org/pubkey.asc    

    NewsMonster - http://www.newsmonster.org/
    
Kevin A. Burton, Location - San Francisco, CA, Cell - 415.595.9965
       AIM/YIM - sfburtonator,  Web - http://peerfear.org/
GPG fingerprint: 5FB2 F3E2 760E 70A8 6174 D393 E84D 8D04 99F1 4412
  IRC - freenode.net #infoanarchy | #p2p-hackers | #newsmonster


Mime
View raw message