Return-Path: Delivered-To: apmail-lucene-java-commits-archive@www.apache.org Received: (qmail 46289 invoked from network); 23 Aug 2009 05:12:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Aug 2009 05:12:55 -0000 Received: (qmail 88448 invoked by uid 500); 23 Aug 2009 05:13:18 -0000 Delivered-To: apmail-lucene-java-commits-archive@lucene.apache.org Received: (qmail 88337 invoked by uid 500); 23 Aug 2009 05:13:17 -0000 Mailing-List: contact java-commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-commits@lucene.apache.org Received: (qmail 88328 invoked by uid 99); 23 Aug 2009 05:13:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Aug 2009 05:13:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Aug 2009 05:13:14 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id A24F52388871; Sun, 23 Aug 2009 05:12:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r806928 - /lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java Date: Sun, 23 Aug 2009 05:12:53 -0000 To: java-commits@lucene.apache.org From: markrmiller@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090823051253.A24F52388871@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: markrmiller Date: Sun Aug 23 05:12:53 2009 New Revision: 806928 URL: http://svn.apache.org/viewvc?rev=806928&view=rev Log: using entry set is faster than looping on key set when you use map.get(key) in loop Modified: lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java Modified: lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java?rev=806928&r1=806927&r2=806928&view=diff ============================================================================== --- lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java (original) +++ lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java Sun Aug 23 05:12:53 2009 @@ -24,6 +24,7 @@ import java.util.List; import java.util.Locale; import java.util.Map; +import java.util.Set; import java.util.WeakHashMap; import org.apache.lucene.document.NumericField; @@ -81,13 +82,14 @@ // that it wasn't GCed before we made hard ref if (null != readerKey && cache.readerCache.containsKey(readerKey)) { Map innerCache = ((Map)cache.readerCache.get(readerKey)); - Iterator keys = innerCache.keySet().iterator(); - while (keys.hasNext()) { - Entry entry = (Entry) keys.next(); + Iterator entrySetIterator = innerCache.entrySet().iterator(); + while (entrySetIterator.hasNext()) { + Map.Entry mapEntry = (Map.Entry) entrySetIterator.next(); + Entry entry = (Entry) mapEntry.getKey(); result.add(new CacheEntryImpl(readerKey, entry.field, cacheType, entry.type, entry.custom, entry.locale, - innerCache.get(entry))); + mapEntry.getValue())); } } }