lucene-java-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yo...@apache.org
Subject svn commit: r488908 - in /lucene/java/trunk: CHANGES.txt src/java/org/apache/lucene/search/FieldCacheImpl.java
Date Wed, 20 Dec 2006 03:47:10 GMT
Author: yonik
Date: Tue Dec 19 19:47:09 2006
New Revision: 488908

URL: http://svn.apache.org/viewvc?view=rev&rev=488908
Log:
fix FieldCache holding hard ref to readers: LUCENE-754

Modified:
    lucene/java/trunk/CHANGES.txt
    lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java

Modified: lucene/java/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/java/trunk/CHANGES.txt?view=diff&rev=488908&r1=488907&r2=488908
==============================================================================
--- lucene/java/trunk/CHANGES.txt (original)
+++ lucene/java/trunk/CHANGES.txt Tue Dec 19 19:47:09 2006
@@ -253,6 +253,11 @@
     {super.finalize();}" to make sure we don't miss finalizers in
     classes above us. (Esmond Pitt via Mike McCandless)
 
+28. LUCENE-754: Fix a problem introduced by LUCENE-651, causing
+    IndexReaders to hang around forever, in addition to not
+    fixing the original FieldCache performance problem.
+    (Chris Hostetter, Yonik Seeley)
+
 Optimizations
 
   1. LUCENE-586: TermDocs.skipTo() is now more efficient for

Modified: lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java?view=diff&rev=488908&r1=488907&r2=488908
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/search/FieldCacheImpl.java Tue Dec 19 19:47:09
2006
@@ -62,7 +62,7 @@
         }
         if (value == null) {
           value = new CreationPlaceholder();
-          innerCache.put(reader, value);
+          innerCache.put(key, value);
         }
       }
       if (value instanceof CreationPlaceholder) {



Mime
View raw message