Return-Path: Delivered-To: apmail-lucene-java-commits-archive@www.apache.org Received: (qmail 58303 invoked from network); 20 Jul 2005 19:11:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 20 Jul 2005 19:11:48 -0000 Received: (qmail 11987 invoked by uid 500); 20 Jul 2005 19:11:47 -0000 Delivered-To: apmail-lucene-java-commits-archive@lucene.apache.org Received: (qmail 11966 invoked by uid 500); 20 Jul 2005 19:11:47 -0000 Mailing-List: contact java-commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-commits@lucene.apache.org Received: (qmail 11953 invoked by uid 99); 20 Jul 2005 19:11:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2005 12:11:47 -0700 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 20 Jul 2005 12:11:41 -0700 Received: (qmail 58281 invoked by uid 65534); 20 Jul 2005 19:11:45 -0000 Message-ID: <20050720191145.58279.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r219965 - in /lucene/java/trunk/src: java/org/apache/lucene/queryParser/MultiFieldQueryParser.java test/org/apache/lucene/queryParser/TestMultiFieldQueryParser.java Date: Wed, 20 Jul 2005 19:11:44 -0000 To: java-commits@lucene.apache.org From: dnaber@apache.org X-Mailer: svnmailer-1.0.2 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dnaber Date: Wed Jul 20 12:11:43 2005 New Revision: 219965 URL: http://svn.apache.org/viewcvs?rev=219965&view=rev Log: fix parsing of sloppy phrase queries and wildcard queries Modified: lucene/java/trunk/src/java/org/apache/lucene/queryParser/MultiFieldQueryParser.java lucene/java/trunk/src/test/org/apache/lucene/queryParser/TestMultiFieldQueryParser.java Modified: lucene/java/trunk/src/java/org/apache/lucene/queryParser/MultiFieldQueryParser.java URL: http://svn.apache.org/viewcvs/lucene/java/trunk/src/java/org/apache/lucene/queryParser/MultiFieldQueryParser.java?rev=219965&r1=219964&r2=219965&view=diff ============================================================================== --- lucene/java/trunk/src/java/org/apache/lucene/queryParser/MultiFieldQueryParser.java (original) +++ lucene/java/trunk/src/java/org/apache/lucene/queryParser/MultiFieldQueryParser.java Wed Jul 20 12:11:43 2005 @@ -21,6 +21,8 @@ import org.apache.lucene.analysis.Analyzer; import org.apache.lucene.search.BooleanClause; import org.apache.lucene.search.BooleanQuery; +import org.apache.lucene.search.MultiPhraseQuery; +import org.apache.lucene.search.PhraseQuery; import org.apache.lucene.search.Query; /** @@ -59,19 +61,31 @@ this.fields = fields; } - protected Query getFieldQuery(String field, String queryText) throws ParseException { + protected Query getFieldQuery(String field, String queryText, int slop) throws ParseException { if (field == null) { Vector clauses = new Vector(); for (int i = 0; i < fields.length; i++) { Query q = super.getFieldQuery(fields[i], queryText); - if (q != null) + if (q != null) { + if (q instanceof PhraseQuery) { + ((PhraseQuery) q).setSlop(slop); + } + if (q instanceof MultiPhraseQuery) { + ((MultiPhraseQuery) q).setSlop(slop); + } clauses.add(new BooleanClause(q, BooleanClause.Occur.SHOULD)); + } } return getBooleanQuery(clauses, true); } return super.getFieldQuery(field, queryText); } + + protected Query getFieldQuery(String field, String queryText) throws ParseException { + return getFieldQuery(field, queryText, 0); + } + /** * @deprecated use {@link #getFieldQuery(String, String)} */ @@ -113,6 +127,18 @@ return super.getPrefixQuery(field, termStr); } + protected Query getWildcardQuery(String field, String termStr) throws ParseException { + if (field == null) { + Vector clauses = new Vector(); + for (int i = 0; i < fields.length; i++) { + clauses.add(new BooleanClause(super.getWildcardQuery(fields[i], termStr), + BooleanClause.Occur.SHOULD)); + } + return getBooleanQuery(clauses, true); + } + return super.getWildcardQuery(field, termStr); + } + /** @throws ParseException * @deprecated use {@link #getRangeQuery(String, String, String, boolean)} */ Modified: lucene/java/trunk/src/test/org/apache/lucene/queryParser/TestMultiFieldQueryParser.java URL: http://svn.apache.org/viewcvs/lucene/java/trunk/src/test/org/apache/lucene/queryParser/TestMultiFieldQueryParser.java?rev=219965&r1=219964&r2=219965&view=diff ============================================================================== --- lucene/java/trunk/src/test/org/apache/lucene/queryParser/TestMultiFieldQueryParser.java (original) +++ lucene/java/trunk/src/test/org/apache/lucene/queryParser/TestMultiFieldQueryParser.java Wed Jul 20 12:11:43 2005 @@ -63,11 +63,17 @@ q = mfqp.parse("[a TO c] two"); assertEquals("(b:[a TO c] t:[a TO c]) (b:two t:two)", q.toString()); + q = mfqp.parse("w?ldcard"); + assertEquals("b:w?ldcard t:w?ldcard", q.toString()); + q = mfqp.parse("\"foo bar\""); assertEquals("b:\"foo bar\" t:\"foo bar\"", q.toString()); q = mfqp.parse("\"aa bb cc\" \"dd ee\""); assertEquals("(b:\"aa bb cc\" t:\"aa bb cc\") (b:\"dd ee\" t:\"dd ee\")", q.toString()); + + q = mfqp.parse("\"foo bar\"~4"); + assertEquals("b:\"foo bar\"~4 t:\"foo bar\"~4", q.toString()); // make sure that terms which have a field are not touched: q = mfqp.parse("one f:two");