From issues-return-5780-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Sun Dec 1 16:54:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ABB1818061A for ; Sun, 1 Dec 2019 17:54:02 +0100 (CET) Received: (qmail 56234 invoked by uid 500); 1 Dec 2019 16:54:02 -0000 Mailing-List: contact issues-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list issues@lucene.apache.org Received: (qmail 56225 invoked by uid 99); 1 Dec 2019 16:54:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Dec 2019 16:54:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2580CE2E13 for ; Sun, 1 Dec 2019 16:54:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 3AD45780477 for ; Sun, 1 Dec 2019 16:54:00 +0000 (UTC) Date: Sun, 1 Dec 2019 16:54:00 +0000 (UTC) From: "Dawid Weiss (Jira)" To: issues@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-13988) Harden CreateCollectionCleanupTest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985615#comment-16985615 ] Dawid Weiss commented on SOLR-13988: ------------------------------------ This is currently super annoying. An alternative take would be to create a valid temp location (folder) and just append a non-existent subfolder to it. > Harden CreateCollectionCleanupTest > ---------------------------------- > > Key: SOLR-13988 > URL: https://issues.apache.org/jira/browse/SOLR-13988 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Minor > Attachments: SOLR-13988.patch > > > This test counts on being unable to create > {code} > /some_invalid_dir/foo > {code} > And if it does somehow succeed, it'll affect the filesystem (which it apparently can at least on Windows under some circumstances and maybe Unix if you're super-user). > It seems safer to create a temp dir and explicitly disable write permissions on it and use that instead. See attached patch. While I don't have a Windows machine to test on, the javadocs assure me that I can disable write perms this way on Windows... > [~anshum][~tflobbe] Does this seem OK to you? -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org For additional commands, e-mail: issues-help@lucene.apache.org