From issues-return-5843-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Mon Dec 2 14:20:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6CD1B18065B for ; Mon, 2 Dec 2019 15:20:02 +0100 (CET) Received: (qmail 87999 invoked by uid 500); 2 Dec 2019 14:20:01 -0000 Mailing-List: contact issues-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list issues@lucene.apache.org Received: (qmail 87972 invoked by uid 99); 2 Dec 2019 14:20:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Dec 2019 14:20:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BDED0E0095 for ; Mon, 2 Dec 2019 14:20:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 335BC78036E for ; Mon, 2 Dec 2019 14:20:00 +0000 (UTC) Date: Mon, 2 Dec 2019 14:20:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: issues@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-9045) Do not use TreeMap/TreeSet in BlockTree and PerFieldPostingsFormat MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986083#comment-16986083 ] ASF subversion and git services commented on LUCENE-9045: --------------------------------------------------------- Commit bb600e363823577fe2cb9b880e76b223fcf28ae8 in lucene-solr's branch refs/heads/branch_8x from Bruno Roustant [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=bb600e3 ] LUCENE-9045: Do not use TreeMap/TreeSet in BlockTree and PerFieldPostingsFormat. Closes #1007 > Do not use TreeMap/TreeSet in BlockTree and PerFieldPostingsFormat > ------------------------------------------------------------------ > > Key: LUCENE-9045 > URL: https://issues.apache.org/jira/browse/LUCENE-9045 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Bruno Roustant > Assignee: Bruno Roustant > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > TreeMap/TreeSet is a heavy structure designed to dynamically sort keys. It's iterator is much less performant than a list iterator. We should not use it when we don't need the sorting capability once built. > And this is the case in BlockTreeTermsReader and PerFieldPostingsFormat. We need a Map and to sort keys at building time. But once built, we don't need to sort anymore, we can use a simple list for iteration efficiency. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org For additional commands, e-mail: issues-help@lucene.apache.org