From issues-return-6109-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Wed Dec 4 14:28:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E233218065B for ; Wed, 4 Dec 2019 15:28:02 +0100 (CET) Received: (qmail 82353 invoked by uid 500); 4 Dec 2019 14:28:02 -0000 Mailing-List: contact issues-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list issues@lucene.apache.org Received: (qmail 82172 invoked by uid 99); 4 Dec 2019 14:28:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Dec 2019 14:28:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C496AE103B for ; Wed, 4 Dec 2019 14:28:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 3B16878007C for ; Wed, 4 Dec 2019 14:28:00 +0000 (UTC) Date: Wed, 4 Dec 2019 14:28:00 +0000 (UTC) From: "Lucene/Solr QA (Jira)" To: issues@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-9042) Refactor TopGroups.merge tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-9042?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D169= 87910#comment-16987910 ]=20 Lucene/Solr QA commented on LUCENE-9042: ---------------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 1 new or modif= ied test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0= m 15s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0= m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {col= or:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {co= lor:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} |= {color:green} 0m 17s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 2= 8s{color} | {color:green} grouping in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 2m 34s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-9042 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1298739= 2/LUCENE-9042.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis v= alidatesourcepatterns | | uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24= 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Buil= d/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / f71c2c8e922 | | ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/240/= testReport/ | | modules | C: lucene/grouping U: lucene/grouping | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/240= /console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Refactor TopGroups.merge tests > ------------------------------ > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Diego Ceccarelli > Priority: Minor > Attachments: LUCENE-9042.patch > > > This=C2=A0task proposes a refactoring of the test coverage for the=C2=A0{= {TopGroups.merge}}=C2=A0method implemented in=C2=A0LUCENE-9010. For now it = will cover only 3 main cases.=C2=A0 > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (curren= tly broken because of=C2=A0LUCENE-8996=C2=A0bug)=C2=A0 > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I w= ould do that in a separate PR to keep the code readable.=C2=A0 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org For additional commands, e-mail: issues-help@lucene.apache.org