lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (Jira)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-9080) "ant regenerate" fails on master
Date Tue, 03 Dec 2019 22:39:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987323#comment-16987323
] 

Erick Erickson commented on LUCENE-9080:
----------------------------------------

The "ant regenerate" target runs with some changes, but it's scary. I made
just a few manual changes, ran the "ant regenerate" target and... a _lot_ 
of files changed. I need some guidance with people more familiar with
this process than I am about whether I should be terrified of all these
changes.

Running precommit and test now, but there's enough here to make me
nervous that I thought I'd ask while they run.

before_regen.patch is the diff of changes I made. Not much really.

after_regen.patch is the diff after executing the "ant regenerate" target.
One thing in particular that bothers me is the change to 
HTMLCharacterEntities.jflex, which percolates into a bunch of other
changes I think.

A number of these are deprecation messages, I'll look
at those, assuming the issue is the source they're generated from.

status.res is the result of "git status" after the regenreate task
completed. Notice that there are a number of files in
lucene/core/src/java/org/apache/lucene/util/packed/
that are untracked. Should they just be deleted?

> "ant regenerate" fails on master
> --------------------------------
>
>                 Key: LUCENE-9080
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9080
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: after_regen.patch, before_regen.patch, status.res
>
>
> The root cause is that RamUsageEstimator.NUM_BYTES_INT has been removed and the python
scripts still reference it in the generated scripts. That part's easy to fix.
> Last time I looked, though, the regenerate produces some differences in the generated
files that should be looked at to insure they're benign.
> Not really sure whether this should be a Lucene or Solr JIRA. Putting it in Lucene since
one of the failed files is: lucene/core/src/java/org/apache/lucene/util/packed/Packed8ThreeBlocks.java
> I do know that one of the Solr jflex-produced file has an unexplained difference so it
may bleed over.
> "ant regenerate" needs about 24G on my machine FWIW.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message