lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Risden (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13996) Refactor HttpShardHandler#prepDistributed() into smaller pieces
Date Tue, 03 Dec 2019 02:17:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986531#comment-16986531
] 

Kevin Risden commented on SOLR-13996:
-------------------------------------

[~ichattopadhyaya] agreed prs can be annoying for changes. Have you tried hub before? https://hub.github.com/
I don't personally use it currently but helps with being able to open pr without web interface

> Refactor HttpShardHandler#prepDistributed() into smaller pieces
> ---------------------------------------------------------------
>
>                 Key: SOLR-13996
>                 URL: https://issues.apache.org/jira/browse/SOLR-13996
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Priority: Major
>         Attachments: SOLR-13996.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, it is very hard to understand all the various things being done in HttpShardHandler.
I'm starting with refactoring the prepDistributed() method to make it easier to grasp. It
has standalone and cloud code intertwined, and wanted to cleanly separate them out. Later,
we can even have two separate method (for standalone and cloud, each).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message