lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13988) Harden CreateCollectionCleanupTest
Date Sun, 01 Dec 2019 16:54:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985615#comment-16985615
] 

Dawid Weiss commented on SOLR-13988:
------------------------------------

This is currently super annoying. An alternative take would be to create a valid temp location
(folder) and just append a non-existent subfolder to it.

> Harden CreateCollectionCleanupTest
> ----------------------------------
>
>                 Key: SOLR-13988
>                 URL: https://issues.apache.org/jira/browse/SOLR-13988
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: SOLR-13988.patch
>
>
> This test counts on being unable to create
> {code}
> /some_invalid_dir/foo
> {code}
> And if it does somehow succeed, it'll affect the filesystem (which it apparently can
at least on Windows under some circumstances and maybe Unix if you're super-user).
> It seems safer to create a temp dir and explicitly disable write permissions on it and
use that instead. See attached patch. While I don't have a Windows machine to test on, the
javadocs assure me that I can disable write perms this way on Windows...
> [~anshum][~tflobbe] Does this seem OK to you?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message