lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Munendra S N (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent
Date Mon, 02 Dec 2019 12:32:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986021#comment-16986021
] 

Munendra S N commented on SOLR-7798:
------------------------------------

I checked the PR, it LGTM but I was not able to apply the patch(generated from PR) cleanly
in local.
Some minor changes
* Please move changes entry to 8.4
* Please include reporter's name in the changes entry

[~mgibney] The reason for fixing NPE by using ArrayList is that {{TermInSetQuery}} internally
converts array to list(this could be avoided but separate issue) but your approach is much
better. I would like to include this in 8.4
Please rebase and update the PR with latest PR template. Let me know if you don't have bandwidth
to do this, I will attach a new patch(so that whole test suite can be run in jenkins. Currently,
this is not yet supported with PR).

[~jbernste] If you don't have any objection, I would like to drive this forward

> Improve robustness of ExpandComponent
> -------------------------------------
>
>                 Key: SOLR-7798
>                 URL: https://issues.apache.org/jira/browse/SOLR-7798
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Jörg Rathlev
>            Assignee: Joel Bernstein
>            Priority: Minor
>         Attachments: expand-component.patch, expand-npe.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{ExpandComponent}} causes a {{NullPointerException}} if accidentally used without
prior collapsing of results.
> If there are multiple documents in the result which have the same term value in the expand
field, the size of the {{ordBytes}}/{{groupSet}} differs from the {{count}} value, and the
{{getGroupQuery}} method creates an incompletely filled {{bytesRef}} array, which later causes
a {{NullPointerException}} when trying to sort the terms.
> The attached patch extends the test to demonstrate the error, and modifies the {{getGroupQuery}}
methods to create the array based on the size of the input maps.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message