lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] eribeiro commented on a change in pull request #1034: SOLR-13863: payload query function now handles string encoded payload field (delimited_payloads_string)
Date Wed, 04 Dec 2019 16:08:20 GMT
eribeiro commented on a change in pull request #1034: SOLR-13863: payload query function now
handles string encoded payload field (delimited_payloads_string)
URL: https://github.com/apache/lucene-solr/pull/1034#discussion_r353827231
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/search/ValueSourceParser.java
 ##########
 @@ -722,6 +722,32 @@ public ValueSource parse(FunctionQParser fp) throws SyntaxError {
 
         TInfo tinfo = parseTerm(fp); // would have made this parser a new separate class
and registered it, but this handy method is private :/
 
+        IndexSchema schema = fp.getReq().getCore().getLatestSchema();
+        final FieldType fieldType = schema.getFieldType(tinfo.field);
+
+        final String payloadEncoder = PayloadUtils.getPayloadEncoder(fieldType);
+        if (payloadEncoder.equals("identity")) {
+
+          ValueSource defaultValueSource;
 
 Review comment:
   Nitpick: turn into terciary operator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message