lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] atris commented on a change in pull request #1049: LUCENE-9074: Slice Allocation Circuit Breakers in IndexSearcher
Date Mon, 02 Dec 2019 16:31:36 GMT
atris commented on a change in pull request #1049: LUCENE-9074: Slice Allocation Circuit Breakers
in IndexSearcher
URL: https://github.com/apache/lucene-solr/pull/1049#discussion_r352697248
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/QueueSizeBasedCircuitBreaker.java
 ##########
 @@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.search;
+
+import java.util.concurrent.Executor;
+import java.util.concurrent.ThreadPoolExecutor;
+
+/**
+ * Blocks allocation based on size of waiting queue for passed in ExecutorService
+ */
+public class QueueSizeBasedCircuitBreaker implements SliceAllocationCircuitBreaker {
+  private final Executor executor;
+  private static final int NUMBER_OF_PROCESSORS = Runtime.getRuntime().availableProcessors();
+  private static final double LIMITING_FACTOR = 1.5;
+
+  public QueueSizeBasedCircuitBreaker(Executor executor) {
+    this.executor = executor;
+  }
+
+  @Override
+  public boolean shouldProceed() {
 
 Review comment:
   Since this is modelling around the concept of Circuit Breakers, I wonder if `hasCircuitBreakerTriggered`
is a better name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message