From issues-return-5372-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Mon Nov 25 17:44:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8C5A1180674 for ; Mon, 25 Nov 2019 18:44:03 +0100 (CET) Received: (qmail 52818 invoked by uid 500); 25 Nov 2019 17:44:02 -0000 Mailing-List: contact issues-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list issues@lucene.apache.org Received: (qmail 52741 invoked by uid 99); 25 Nov 2019 17:44:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Nov 2019 17:44:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E8D50E30C8 for ; Mon, 25 Nov 2019 17:44:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 65A107804CE for ; Mon, 25 Nov 2019 17:44:00 +0000 (UTC) Date: Mon, 25 Nov 2019 17:44:00 +0000 (UTC) From: "Michael Sokolov (Jira)" To: issues@lucene.apache.org Message-ID: In-Reply-To: References: Subject: =?utf-8?Q?[jira]_[Comment_Edited]_(LUCENE-9064)_Can_we_rem?= =?utf-8?Q?ove_the_FST_cache_in_Kuromoji=C2=A0and_Nori_analyzers=3F?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-9064?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D169= 81739#comment-16981739 ]=20 Michael Sokolov edited comment on LUCENE-9064 at 11/25/19 5:43 PM: ------------------------------------------------------------------- [~bruno.roustant] there is \{TestJapaneseTokenizer.testWikipedia} (commente= d out). To get it running you must download jawiki from wikipedia and edit = the test to point at the file you downloaded. You might also have to disabl= e secutiry manager checks that prevent reading from random places in the fi= lesystem. was (Author: sokolov): [~bruno.roustant] there is \{TestJapaneseTokenizer.testWikipedia}. To get i= t running you must download jawiki from wikipedia and edit the test to poin= t at the file you downloaded. You might also have to disable secutiry manag= er checks that prevent reading from random places in the filesystem. > Can we remove the FST cache in Kuromoji=C2=A0and Nori analyzers? > ----------------------------------------------------------- > > Key: LUCENE-9064 > URL: https://issues.apache.org/jira/browse/LUCENE-9064 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Bruno Roustant > Priority: Minor > > Is the ~30k han cache in kuromoji redundant after=C2=A0LUCENE-8920? > [https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a4= 66a70f969a3/lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja= /dict/TokenInfoFST.java#L35-L38]) > The entire linked file's purpose is all around this caching, so if its no= t needed anymore it would be a nice cleanup. But it was definitely needed f= or good performance before, so we shoudl be careful. Nori analyzer has the = exact same thing (file has the same name) for ~10k hangul syllables. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org For additional commands, e-mail: issues-help@lucene.apache.org