From issues-return-4423-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Wed Nov 13 12:41:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8D50318067C for ; Wed, 13 Nov 2019 13:41:02 +0100 (CET) Received: (qmail 99719 invoked by uid 500); 13 Nov 2019 12:41:01 -0000 Mailing-List: contact issues-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list issues@lucene.apache.org Received: (qmail 99705 invoked by uid 99); 13 Nov 2019 12:41:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Nov 2019 12:41:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C281CE2DF0 for ; Wed, 13 Nov 2019 12:41:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 216EE780395 for ; Wed, 13 Nov 2019 12:41:00 +0000 (UTC) Date: Wed, 13 Nov 2019 12:41:00 +0000 (UTC) From: "Diego Ceccarelli (Jira)" To: issues@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-9042) Refactor TopGroups.merge tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-9042?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D169= 73309#comment-16973309 ]=20 Diego Ceccarelli commented on LUCENE-9042: ------------------------------------------ patch updated to fix the javac warnings.=C2=A0 > Refactor TopGroups.merge tests > ------------------------------ > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Diego Ceccarelli > Priority: Minor > Attachments: LUCENE-9042.patch > > > This=C2=A0task proposes a refactoring of the test coverage for the=C2=A0{= {TopGroups.merge}}=C2=A0method implemented in=C2=A0LUCENE-9010. For now it = will cover only 3 main cases.=C2=A0 > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (curren= tly broken because of=C2=A0LUCENE-8996=C2=A0bug)=C2=A0 > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I w= ould do that in a separate PR to keep the code readable.=C2=A0 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org For additional commands, e-mail: issues-help@lucene.apache.org