From issues-return-5399-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Tue Nov 26 00:24:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 38010180674 for ; Tue, 26 Nov 2019 01:24:40 +0100 (CET) Received: (qmail 82972 invoked by uid 500); 26 Nov 2019 00:24:39 -0000 Mailing-List: contact issues-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list issues@lucene.apache.org Received: (qmail 82733 invoked by uid 99); 26 Nov 2019 00:24:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Nov 2019 00:24:38 +0000 From: GitBox To: issues@lucene.apache.org Subject: [GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching Message-ID: <157472787859.20661.7645427384225492525.gitbox@gitbox.apache.org> Date: Tue, 26 Nov 2019 00:24:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350481687 ########## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/MultiTermHighlighting.java ########## @@ -86,85 +87,10 @@ public QueryVisitor getSubVisitor(BooleanClause.Occur occur, Query parent) { } @Override - public void visitLeaf(Query query) { Review comment: Of course I love this. I recall when I worked on some of this I advocated that the automata stuff had some of this logic so that the Highlighters wouldn't have to deal with it... but nobody had responded at the time. I'm really glad to see you addressing this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org For additional commands, e-mail: issues-help@lucene.apache.org