From issues-return-4458-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Wed Nov 13 16:04:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D0296180621 for ; Wed, 13 Nov 2019 17:04:19 +0100 (CET) Received: (qmail 99168 invoked by uid 500); 13 Nov 2019 16:04:19 -0000 Mailing-List: contact issues-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list issues@lucene.apache.org Received: (qmail 99159 invoked by uid 99); 13 Nov 2019 16:04:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Nov 2019 16:04:19 +0000 From: GitBox To: issues@lucene.apache.org Subject: [GitHub] [lucene-solr] jpountz commented on a change in pull request #973: LUCENE-9027: Use SIMD instructions to decode postings. Message-ID: <157366105907.10848.5554394393449516815.gitbox@gitbox.apache.org> Date: Wed, 13 Nov 2019 16:04:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jpountz commented on a change in pull request #973: LUCENE-9027: Use SIMD instructions to decode postings. URL: https://github.com/apache/lucene-solr/pull/973#discussion_r345847792 ########## File path: lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java ########## @@ -63,7 +69,16 @@ public static ByteBufferIndexInput newInstance(String resourceDescription, ByteB assert chunkSizePower >= 0 && chunkSizePower <= 30; assert (length >>> chunkSizePower) < Integer.MAX_VALUE; } - + + protected void setCurBuf(ByteBuffer curBuf) { Review comment: I could also build the LongBuffer view on demand if that works better for you. Are you more worried about CPU, memory or both? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org For additional commands, e-mail: issues-help@lucene.apache.org