From issues-return-4131-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Sat Nov 9 13:36:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C5A2E180668 for ; Sat, 9 Nov 2019 14:36:56 +0100 (CET) Received: (qmail 12779 invoked by uid 500); 9 Nov 2019 13:36:56 -0000 Mailing-List: contact issues-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list issues@lucene.apache.org Received: (qmail 12679 invoked by uid 99); 9 Nov 2019 13:36:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Nov 2019 13:36:55 +0000 From: GitBox To: issues@lucene.apache.org Subject: [GitHub] [lucene-solr] noblepaul commented on a change in pull request #994: SOLR-13662: Package Manager (CLI) Message-ID: <157330661591.16085.7627145318868461998.gitbox@gitbox.apache.org> Date: Sat, 09 Nov 2019 13:36:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit noblepaul commented on a change in pull request #994: SOLR-13662: Package Manager (CLI) URL: https://github.com/apache/lucene-solr/pull/994#discussion_r344444367 ########## File path: solr/core/src/java/org/apache/solr/packagemanager/SolrPackage.java ########## @@ -0,0 +1,107 @@ +package org.apache.solr.packagemanager; + + +import java.io.Serializable; +import java.util.Date; +import java.util.List; +import java.util.Map; + +import com.fasterxml.jackson.annotation.JsonProperty; Review comment: use `org.apache.solr.common.annotation.JsonProperty` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org For additional commands, e-mail: issues-help@lucene.apache.org