lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (Jira)" <>
Subject [jira] [Resolved] (SOLR-13952) Added SuppressWarnings and similar minor matters
Date Mon, 25 Nov 2019 20:14:00 GMT


Erick Erickson resolved SOLR-13952.
    Resolution: Won't Fix

AFAIC, this is more effort than it's worth just to remove some warnings. I'll still work on
the linked Jira for substantive changes.

> Added SuppressWarnings and similar minor matters
> ------------------------------------------------
>                 Key: SOLR-13952
>                 URL:
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-13952.patch, fordavid.patch
> The gradle_8 branch has many changes unrelated to gradle. It would be much easier to
work on the gradle parts if these were separated. So here's my plan:
> This turned out not to be as hard as I expected. I'll create a sub-task for the functional
changes and use this one for the non-functional changes. Non-functional changes are the overwhelming
majority of changes. There are a few categories of change here:
> * SuppressWarnings, rawtypes, deprecated.
> * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter and QuickPatchThreadsFilter.
These are know thread leaks from third-party products (IBM Java, and a Log4J2 thread was added)
> * some static imports were removed
> * some reformatting, given that this whole patch is not about functional changes I decided
to leave them in.
> * Some very minor code changes:
> ** change "new Path(leaderPath).getParent().toString();"  to "Paths.get(leaderPath).getParent().toString();"
> ** mods like new HashMap(); <- new HashMap<>();
> * Log messages added

This message was sent by Atlassian Jira

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message