lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
Date Sun, 24 Nov 2019 18:50:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981155#comment-16981155
] 

Erick Erickson commented on SOLR-13952:
---------------------------------------

l'll close this JIRA when the sub-task is done.

> Separate out Gradle-specific code from other (mostly test) changes and commit separately
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-13952
>                 URL: https://issues.apache.org/jira/browse/SOLR-13952
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-13952.patch, fordavid.patch
>
>
> The gradle_8 branch has many changes unrelated to gradle. It would be much easier to
work on the gradle parts if these were separated. So here's my plan:
> This turned out not to be as hard as I expected. I'll create a sub-task for the functional
changes and use this one for the non-functional changes. Non-functional changes are the overwhelming
majority of changes. There are a few categories of change here:
> * SuppressWarnings, rawtypes, deprecated.
> * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter and QuickPatchThreadsFilter.
These are know thread leaks from third-party products (IBM Java, and a Log4J2 thread was added)
> * some static imports were removed
> * some reformatting, given that this whole patch is not about functional changes I decided
to leave them in.
> * Some very minor code changes:
> ** change "new Path(leaderPath).getParent().toString();"  to "Paths.get(leaderPath).getParent().toString();"
> ** mods like new HashMap(); <- new HashMap<>();
> * Log messages added



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message