lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13941) Tests configure Jetty differently than when running via start.jar
Date Mon, 18 Nov 2019 23:15:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976967#comment-16976967
] 

Uwe Schindler commented on SOLR-13941:
--------------------------------------

Hi,
You can also remove the obsolete servlet from source code. 
The reason why the servlet was needed is caused by this binding without a slash: the container
sees no matching servlet on Root path, because * is an invalid mapping, that should be used
for file extensions only. So the 404 servlet is needed as a workaround to make container happy.

Could you please also fix the DebugFilter mapping a few lines above? It has same issue.

> Tests configure Jetty differently than when running via start.jar
> -----------------------------------------------------------------
>
>                 Key: SOLR-13941
>                 URL: https://issues.apache.org/jira/browse/SOLR-13941
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Jan H√łydahl
>            Assignee: Uwe Schindler
>            Priority: Major
>         Attachments: SOLR-13941.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Spinoff from SOLR-13905.
> There seems to be a slightly different configuration of our servlets when Solr is run
from command line and through Test-runner for our tests.
> This causes different behavior of {{httpRequest.getPathInfo}} and {{httpRequest.getServletPath()}}
in the two environments, making it hard to depend on these in critical code paths, such as
[SolrDispatchFilter|https://github.com/apache/lucene-solr/blob/f07998fc234c81ff956a84ee508b85f8d573ef38/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java#L494-L499]
and AuditEvent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message