lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
Date Sun, 17 Nov 2019 18:35:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976120#comment-16976120
] 

Erick Erickson commented on SOLR-13939:
---------------------------------------

Thanks for summarizing this. I'd hate to lose the work if it'll improve tests. The deprecations
have to be addressed sometime, I'm less worried about those but why lose the effort?

bq. It is really crucial to have these isolated from the gradle branch....

Agreed, there's too much conflated in this single branch.

On a _very_ quick diff of the branches and then trying to eliminate everything that looks
gradle-related, I see diffs in 100 Lucene files and 200 Solr files +/-. 

How should we take this forward? Maybe make a branch off master that we can use for incorporating
the non-gradle changes, incorporate them, then make a gradle_9 branch off the then-current
master that contains _just_ the Gradle changes?

Or go the opposite way. Merge the gradle_8 branch into a new branch off master then back all
the gradle-related changes out. Then make a gradle_9 branch with the gradle-related changes
added back.

Or ??? I'll gladly defer to whatever approach anyone driving the bus thinks is appropriate,
the above are strictly straw-man.

Let me know if/when I can put some effort into this without stepping on other's work. I'll
be glad to see what I can do with the solr changes when appropriate. If you want to drive
this bus, just let me know what would be helpful. If that means I should just cool my jets
until you ping me I have other projects to keep me occupied...

Thanks again!

> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-13939
>                 URL: https://issues.apache.org/jira/browse/SOLR-13939
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Dawid Weiss
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message