lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
Date Sun, 17 Nov 2019 17:31:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976094#comment-16976094
] 

Dawid Weiss commented on SOLR-13939:
------------------------------------

Mark applied many small changes throughout the codebase that deviate the gradle effort from
master branch – this complicates looking at what is really the gradle-related stuff and
what is not. There are three axes of changes:
 * gradle-related (build files, dependencies, etc.),
 * deprecation annotations and other compiler-warning related fixes,
 * Solr test-related fixes (thread leaks, minor changes to zk stuff I have no idea about).

It is really crucial to have these isolated from the gradle branch because it facilitates
merging against master and just provides a clearer view of what really is related to the gradle
build effort. Deprecation annotations should be applied to the master branch, then merged
back to gradle branch. Solr test-related efforts – I have no idea. I don't know that code
and test instability is something not related to gradle so I don't think these concerns should
be mixed.

 

> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-13939
>                 URL: https://issues.apache.org/jira/browse/SOLR-13939
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Dawid Weiss
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message