lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13915) Figure out the equivalent of "ant dist server" in the Gradle build
Date Sat, 16 Nov 2019 02:09:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975532#comment-16975532
] 

Erick Erickson commented on SOLR-13915:
---------------------------------------

I made some progress tonight. The ant build populates three directories with various jar files:

{code}
../solr/server/solr-webapp/webapp/WEB-INF/lib/
    - Lucene, many dependencies, solr-core, and solr-solrj jar files.
../solr/server/lib/ext/
  - logging jars
../solr/server/lib/
  - jetty, http2 jars, and metrics jars
{code}

Near as I can tell, we don't try to do any of this in the Gradle build with any task. We also
have to create the start.jar file in the right place, but there's a task that already does
that we can co-opt into a new task: 
{code}
gw solr:solr-server:getStartJar
{code}

I suspect there's more to do than just copy the files, but that's at least the first step.
I manually copied the files from an Ant build into the directories above (from a different
clone) and at least got farther, bin/solr started rather than give me a "class not found"
error, admittedly it then just hung, but that's the next step.

So, finally to my question: What's the right thing to do here? Do we need three separate directories
or are there holdovers from when we distributed Solr as a war file? Can we just copy them
all into the same directory? 

In any case, does it make sense to continue to use "solr-webapp/webapp/WEB-INF/lib/"

My initial take is that, given the ability to drop different logging into Solr, having the
../solr/server/lib/ext contain _only_ logging-related jars makes sense, but should we have
the other two be separate?

Mind you, this reveals lots I've been able to successfully ignore for a long time while working
with Solr...

> Figure out the equivalent of "ant dist server" in the Gradle build
> ------------------------------------------------------------------
>
>                 Key: SOLR-13915
>                 URL: https://issues.apache.org/jira/browse/SOLR-13915
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>
> Who knows? Perhaps this already happens in the Gradle build and I just don't know the
magic.
> Whether we actually require an equivalent of both targets is an open question. The goal
is to be able to execute some target, then execute "bin/solr start".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message