lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13905) Nullpointer exception in AuditEvent
Date Sat, 16 Nov 2019 09:38:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975650#comment-16975650
] 

Uwe Schindler commented on SOLR-13905:
--------------------------------------

I think this has to do that real life uses a full features Jetty server with a web application,
which the tests use embedded Jetty that's configured in code. As communicated many times,
we should really get rid of the webapp and do the productive part in the same way, but until
this is done there may be some differenceds. I think that has to do with context resolves.
getPathInfo() depends very hard on how the pattern is configured (if there is a wildcard in
the servlet path) or not. 

What is exactly the difference? No pathinfo at all? Or is one giving path starting from context
root, while the other one only the part behind the servlet name?

> Nullpointer exception in AuditEvent
> -----------------------------------
>
>                 Key: SOLR-13905
>                 URL: https://issues.apache.org/jira/browse/SOLR-13905
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Auditlogging
>    Affects Versions: 8.3
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>            Priority: Major
>             Fix For: 8.4, 8.3.1
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Nullpointer exception in AuditEvent for events with HttpServletRequest as input. Happens
when {{getPathInfo()}} returns null, which was not caught by current tests. This causes
the whole request to fail, rendering the audit service unusable.
> The nullpointer is experienced in the {{findRequestType()}} method when performing pattern
match on the resource (path).
> This is a regression from 8.3, caused by SOLR-13835 where we switched from fetching
the URL path from {{httpRequest.getContextPath()}} to {{httpRequest.getPathInfo()}}. However
while this method behaves well in tests (JettyTestRunner) it returns {{null}} in production.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message