lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (Jira)" <>
Subject [jira] [Created] (SOLR-13898) Non-atomic use of SolrCache get / put
Date Tue, 05 Nov 2019 19:13:00 GMT
Andrzej Bialecki created SOLR-13898:

             Summary: Non-atomic use of SolrCache get / put
                 Key: SOLR-13898
             Project: Solr
          Issue Type: Bug
      Security Level: Public (Default Security Level. Issues are Public)
    Affects Versions: 8.3
            Reporter: Andrzej Bialecki
            Assignee: Andrzej Bialecki

As pointed out by [~ben.manes] in SOLR-13817 Solr code base in many key places uses a similar
pattern of non-atomic get / put calls to SolrCache-s. In multi-threaded environment this leads
to cache misses and additional unnecessary computations when competing threads both discover
a missing value, non-atomically compute it and update the cache.

Some of these places are known performance bottlenecks where efficient caching is especially
important, such as {{SolrIndexSearcher}}, {{SolrDocumentFetcher}}, {{UninvertedField}} and
join queries .

I propose to add {{SolrCache.computeIfAbsent(key, mappingFunction)}} that will atomically
retrieve existing values or compute and update the cache. This will require also changing
how the {{SolrCache.get(...)}} is used in many components.

This message was sent by Atlassian Jira

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message