lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Khludnev (Jira)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-9026) Make it easier to extend DocValuesTermsQuery
Date Mon, 04 Nov 2019 22:15:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967049#comment-16967049
] 

Mikhail Khludnev commented on LUCENE-9026:
------------------------------------------

{quote}I'm considering extending the query to implement Solr's [PostFilter|https://lucene.apache.org/solr/8_2_0/solr-core/org/apache/solr/search/PostFilter.html] interface.
The ultimate goal of this is to make it more efficient to run this query with very large numbers
of terms.
{quote}
Hello, [~gerlowskija]. 

Please notice [method=docValuesTermsFilter|https://lucene.apache.org/solr/guide/7_3/other-parsers.html#terms-query-parser],
I suppose it's done it underneath.  

> Make it easier to extend DocValuesTermsQuery
> --------------------------------------------
>
>                 Key: LUCENE-9026
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9026
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: master (9.0)
>            Reporter: Jason Gerlowski
>            Priority: Minor
>         Attachments: LUCENESOLR-9026.patch
>
>
> The visibility of some of the fields in DocValuesTermsQuery make it difficult to efficiently
subclass.  Especially the "termData" instance variable, which is really core to the functioning
of the class but is totally inaccessible from any sub-classes, forcing subclasses to store
a duplicate PrefixCodedTerms object, and then juggle the state of both.
> Are there any objections to making "termData" (and potentiall some other instance variables)
protected instead of private for this class?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message