lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (Jira)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-9018) Separator for ConcatenateGraphFilterFactory
Date Sun, 10 Nov 2019 14:14:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971132#comment-16971132
] 

David Smiley commented on LUCENE-9018:
--------------------------------------

Thanks.

There is a backwards-compatibility concern we overlooked.  You can call getLuceneMatchVersion()
in the factory to switch between old behavior and new.  The old should retain "preserveSep"
with non-configurable separator.  The new behavior I think should have a similar default such
that if you don't specify anything about the separator, you get the same separator char we
get today.  We don't want/need to change the semantics.   getCharacter on an empty string
can mean null.

RE CompletionAnalyzer, I'm skeptical you should change it's public API since I suspect this
level of configurability is not useful for that feature?

> Separator for ConcatenateGraphFilterFactory
> -------------------------------------------
>
>                 Key: LUCENE-9018
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9018
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Stanislav Mikulchik
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-9018.patch, LUCENE-9018.patch
>
>
> I would like to have an option to choose a separator to use for token concatenation.
Currently ConcatenateGraphFilterFactory can use only "\u001F" symbol.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message