lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <>
Subject [jira] [Commented] (SOLR-12028) BadApple and AwaitsFix annotations usage
Date Sat, 16 Nov 2019 15:11:00 GMT


ASF subversion and git services commented on SOLR-12028:

Commit e6dc96d4d8d09fa70947c94ce1388be52acc42bf in lucene-solr's branch refs/heads/branch_8x
from Chris M. Hostetter
[;h=e6dc96d ]

TestDistributedStatsComponentCardinality: Remove @BadApple anotation

This test was originally anotated @BadApple ~2018-10-14 as pat of SOLR-12028.

So far in 2019, it has failed in 62 jenkins-BadApple builds, but all prior to 2019-06-14.

Since we no longer have logs from those older jenkins builds, it's hard to be certain how/why
this test was failing, or why exactly it *stopped* failing -- but a likely suspect is that
the root cause of the problem may have been fixed as part of the Jetty upgrade in SOLR-13541.

(cherry picked from commit 3fb39b2960ae3b04d8f97a683a8c9daaef3f4696)

> BadApple and AwaitsFix annotations usage
> ----------------------------------------
>                 Key: SOLR-12028
>                 URL:
>             Project: Solr
>          Issue Type: Task
>          Components: Tests
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-12016-buildsystem.patch, SOLR-12028-3-Mar.patch, SOLR-12028-sysprops-reproduce.patch,
SOLR-12028.patch, SOLR-12028.patch
> There's a long discussion of this topic at SOLR-12016. Here's a summary:
> - BadApple annotations are used for tests that intermittently fail, say < 30% of the
time. Tests that fail more often shold be moved to AwaitsFix. This is, of course, a judgement
> - AwaitsFix annotations are used for tests that, for some reason, the problem can't be
fixed immediately. Likely reasons are third-party dependencies, extreme difficulty tracking
down, dependency on another JIRA etc.
> Jenkins jobs will typically run with BadApple disabled to cut down on noise. Periodically
Jenkins jobs will be run with BadApples enabled so BadApple tests won't be lost and reports
can be generated. Tests that run with BadApples disabled that fail require _immediate_ attention.
> The default for developers is that BadApple is enabled.
> If you are working on one of these tests and cannot get the test to fail locally, it
is perfectly acceptable to comment the annotation out. You should let the dev list know that
this is deliberate.
> This JIRA is a placeholder for BadApple tests to point to between the times they're identified
as BadApple and they're either fixed or changed to AwaitsFix or assigned their own JIRA.
> I've assigned this to myself to track so I don't lose track of it. No one person will
fix all of these issues, this will be an ongoing technical debt cleanup effort.

This message was sent by Atlassian Jira

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message