lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] janhoy commented on a change in pull request #153: Fix issues reported by findbugs
Date Wed, 27 Nov 2019 08:13:48 GMT
janhoy commented on a change in pull request #153: Fix issues reported by findbugs
URL: https://github.com/apache/lucene-solr/pull/153#discussion_r351139956
 
 

 ##########
 File path: solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/XLSXResponseWriter.java
 ##########
 @@ -357,7 +357,7 @@ public void writeArray(String name, Iterator val) throws IOException
{
       if (v instanceof IndexableField) {
         IndexableField f = (IndexableField)v;
         if (v instanceof Date) {
-          output.append(((Date) val).toInstant().toString() + "; ");
+          output.append(((Date) v).toInstant().toString() + "; ");
 
 Review comment:
   This looks legitimate - Would cause a classCastException. But have we ever seen it in the
wild?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message