lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] dweiss commented on a change in pull request #1031: LUCENE-9059: Reduce garbage created by ByteBuffersDataOutput.
Date Tue, 26 Nov 2019 09:18:01 GMT
dweiss commented on a change in pull request #1031: LUCENE-9059: Reduce garbage created by
ByteBuffersDataOutput.
URL: https://github.com/apache/lucene-solr/pull/1031#discussion_r350618719
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
 ##########
 @@ -412,7 +413,11 @@ public long ramBytesUsed() {
    * lead to hard-to-debug issues, use with great care.
    */
   public void reset() {
-    blocks.stream().forEach(blockReuse);
+    if (blockReuse != NO_REUSE) {
 
 Review comment:
   That .stream() call is actually not necessary there -- you could just pass a closure to
blocks.forEach... This should be pretty much equivalent to having a for loop. I don't mind
switching to more verbose format, I just wanted be hip and groovy with streams...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message