lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching
Date Tue, 26 Nov 2019 00:24:38 GMT
dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching
URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350481687
 
 

 ##########
 File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/MultiTermHighlighting.java
 ##########
 @@ -86,85 +87,10 @@ public QueryVisitor getSubVisitor(BooleanClause.Occur occur, Query parent)
{
     }
 
     @Override
-    public void visitLeaf(Query query) {
 
 Review comment:
   Of course I love this.  I recall when I worked on some of this I advocated that the automata
stuff had some of this logic so that the Highlighters wouldn't have to deal with it... but
nobody had responded at the time.  I'm really glad to see you addressing this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message