lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1039: SOLR-13968: Support postingsFormat and docValuesFormat in schema fields
Date Mon, 25 Nov 2019 21:27:31 GMT
bruno-roustant commented on a change in pull request #1039: SOLR-13968: Support postingsFormat
and docValuesFormat in schema fields
URL: https://github.com/apache/lucene-solr/pull/1039#discussion_r350431085
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/schema/FieldProperties.java
 ##########
 @@ -85,7 +93,7 @@ static int propertyNameToInt(String name, boolean failOnError) {
         return 1 << i;
       }
     }
-    if (failOnError && !"default".equals(name)) {
+    if (failOnError && !IGNORED_PROPERTY_NAMES.contains(name)) {
 
 Review comment:
   Indeed a method "isPropertyIgnored" is clearer, thanks.
   However I prefer a simple triple String equals rather than a switch, because I find the
first more concise and actually faster for only 3 strings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message