lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] tflobbe commented on a change in pull request #1023: SOLR-13950: Fix getLeaderRetry swallowing interrupt in ZkStateReader
Date Thu, 21 Nov 2019 00:40:21 GMT
tflobbe commented on a change in pull request #1023: SOLR-13950: Fix getLeaderRetry swallowing
interrupt in ZkStateReader
URL: https://github.com/apache/lucene-solr/pull/1023#discussion_r348846517
 
 

 ##########
 File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
 ##########
 @@ -968,7 +968,10 @@ public Replica getLeaderRetry(String collection, String shard, int timeout)
thro
         }
         return false;
       });
-    } catch (TimeoutException | InterruptedException e) {
+    } catch (InterruptedException e) {
+      Thread.currentThread().interrupt();
+      throw e;
 
 Review comment:
   And BTW, I'm +1 with letting it bubble up

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message