lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] uschindler commented on a change in pull request #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml
Date Tue, 19 Nov 2019 16:56:35 GMT
uschindler commented on a change in pull request #1018: SOLR-13941: Configure JettySolrRunner
same as in web.xml
URL: https://github.com/apache/lucene-solr/pull/1018#discussion_r347660797
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/servlet/ServletUtils.java
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.servlet;
+
+import javax.servlet.http.HttpServletRequest;
+
+/**
+ * Various Util methods for interaction on servlet level, i.e. HttpServletRequest
+ */
+public class ServletUtils {
 
 Review comment:
   Please make this class abstract and/or add a private ctor. Or make it an interface with
only static methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message