lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] janhoy opened a new pull request #1014: SOLR-13905 Fix AuditEvent NPE
Date Fri, 15 Nov 2019 14:41:19 GMT
janhoy opened a new pull request #1014: SOLR-13905 Fix AuditEvent NPE
URL: https://github.com/apache/lucene-solr/pull/1014
 
 
   <!--
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene
or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull
requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with
code review comments and commits. -->
   
   
   # Description
   
   Got NPE for some Audit events such as early errors, due to the way we constructed the resource
variable from `httpRequest.getPathInfo()`, which could return null in some environments. Sadly
it does not return null in our test env, but on a real server it does.
   
   Also, around the code that triggered the NPE we looped through a bunch of REGEX strings
and compiled each one for every request.
   
   # Solution
   
   Solution is to always start with `httpRequest.getServletPath()` which always returns something,
and then concatenate `getPathInfo()` if it is non-null.
   
   The Path-to-RequestType guessing logic now uses compiled static RegEx Patterns for speed,
and also is null-safe in that it explicitly checks.
   
   # Tests
   
   The test does not prove the NPE, but it tests an ERROR case that is correctly classified
as ADMIN.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute)
and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I am authorized to contribute this code to the ASF and have removed any code I do
not have a license to distribute.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [x] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide)
(for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message