lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] mkhludnev commented on a change in pull request #985: LUCENE-9031: test unified highlighter on intervals queries
Date Wed, 06 Nov 2019 04:11:11 GMT
mkhludnev commented on a change in pull request #985: LUCENE-9031: test unified highlighter
on intervals queries
URL: https://github.com/apache/lucene-solr/pull/985#discussion_r342909762
 
 

 ##########
 File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/IntervalMatches.java
 ##########
 @@ -74,7 +75,7 @@ public MatchesIterator getSubMatches() throws IOException {
 
       @Override
       public Query getQuery() {
-        throw new UnsupportedOperationException();
+        return query==null ? query = new IntervalQuery(field, intervalsSource) : query;
 
 Review comment:
   well .. It's a static method, hence, there's no query instance, even IntervalSources which
invoke this method.. So, don't know where to get  ```source.getQuery()```, but I like the
idea. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message