lucene-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] romseygeek commented on a change in pull request #985: LUCENE-9031: test unified highlighter on intervals queries
Date Tue, 05 Nov 2019 14:33:51 GMT
romseygeek commented on a change in pull request #985: LUCENE-9031: test unified highlighter
on intervals queries
URL: https://github.com/apache/lucene-solr/pull/985#discussion_r342592911
 
 

 ##########
 File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/CachingMatchesIterator.java
 ##########
 @@ -43,16 +44,21 @@ private void cache() throws IOException {
       posAndOffsets[1] = in.endPosition();
       posAndOffsets[2] = in.startOffset();
       posAndOffsets[3] = in.endOffset();
+      mathchingQueries [0] = in.getQuery();
     }
     else {
       while (mi.next()) {
         if (count * 4 >= posAndOffsets.length) {
           posAndOffsets = ArrayUtil.grow(posAndOffsets, (count + 1) * 4);
         }
+        if (count >= mathchingQueries.length) {
 
 Review comment:
   You can fold this into the conditional above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Mime
View raw message