Mailing-List: contact general-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@lucene.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Mime-Version: 1.0 (Apple Message framework v734)
In-Reply-To: <430B3DDD.9000604@gmx.de>
References: <430B3DDD.9000604@gmx.de>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <535F3DBA-9457-444C-850E-806F03C8A752@ehatchersolutions.com>
Content-Transfer-Encoding: 7bit
From: Erik Hatcher <erik@ehatchersolutions.com>
Subject: Re: Little improvement for SimpleHTMLEncoder
Date: Tue, 23 Aug 2005 14:11:32 -0400
To: general@lucene.apache.org

Could you add this to a Bugzilla issue so it doesn't get lost in the  
never ending pile of e-mail that we all have?

Thanks,
     Erik

On Aug 23, 2005, at 11:16 AM, Stefan Wachter wrote:

> Hi all!
>
> The SimpleHTMLEncoder could be improved slightly: all characters  
> with code >= 128 should be encoded as character entities. The  
> reason is, that the encoder does not know the encoding that is used  
> for the response. Therefore it is safer to encode all characters  
> beyond ASCII as character entities. Can someone judge this proposal  
> and commit it eventually?
>
> Greetings!
> --Stefan
>
>
>        default:
>          if (c < 128) {
>            result.append(c);
>          } else {
>            result.append("&#").append((int)c).append(";");
>          }
>
>