From dev-return-359491-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Tue Jun 18 09:01:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B599F18066B for ; Tue, 18 Jun 2019 11:01:02 +0200 (CEST) Received: (qmail 10138 invoked by uid 500); 18 Jun 2019 09:01:00 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 10126 invoked by uid 99); 18 Jun 2019 09:01:00 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2019 09:01:00 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65179E2DB7 for ; Tue, 18 Jun 2019 09:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2BF9E24654 for ; Tue, 18 Jun 2019 09:01:00 +0000 (UTC) Date: Tue, 18 Jun 2019 09:01:00 +0000 (UTC) From: "Adrien Grand (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8862?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 66364#comment-16866364 ]=20 Adrien Grand commented on LUCENE-8862: -------------------------------------- I'd like to avoid adding new methods to the collector API for this. I don't= think the collector API needs a visitor API since there aren't many use-ca= ses for collecting multiple collectors at once via a MultiCollector, especi= ally since Lucene 8 and top-hits retrieval optimizations: if you want to re= trieve both top hits and facets, it is likely a better idea now to run the = query twice concurrently, once with a top-hits collector and another time w= ith a faceting collector. This will enable the UI to start displaying top h= its while facets are still being computed. Furthermore exposing internals o= f collectors via a visitor API might prevent some optimizations or the cont= ract would be a bit weird. For instance MultiLeafCollector removes its sub = collectors when they throw a CollectionTerminatedException, should we visit= these sub collectors or not? We have a similar problem with the Scorer#get= Children API and the BooleanScorer optimization, which makes the Scorer#get= Children API hard to rely on since it is not consistently implemented. > Collector Level Dynamic Memory Accounting > ----------------------------------------- > > Key: LUCENE-8862 > URL: https://issues.apache.org/jira/browse/LUCENE-8862 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Atri Sharma > Priority: Major > > Inspired from LUCENE-8855, I am thinking of adding a new interface which = tracks dynamic memory used by Collectors. This shall allow users to get an = accountability as to the memory usage of their Collectors and better plan t= heir resource capacity. This shall also allow us to add Collector level lim= its for memory usage, thus allowing users a finer control over their resour= ces. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org