From dev-return-360401-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Tue Jun 25 17:40:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D01F218062F for ; Tue, 25 Jun 2019 19:40:02 +0200 (CEST) Received: (qmail 74552 invoked by uid 500); 25 Jun 2019 17:40:01 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 74535 invoked by uid 99); 25 Jun 2019 17:40:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jun 2019 17:40:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 91DEEE2E1B for ; Tue, 25 Jun 2019 17:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F1C925814 for ; Tue, 25 Jun 2019 17:40:00 +0000 (UTC) Date: Tue, 25 Jun 2019 17:40:00 +0000 (UTC) From: "Andrzej Bialecki (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8855) Add Accountable to Query implementations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8855?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 72558#comment-16872558 ]=20 Andrzej Bialecki commented on LUCENE-8855: ------------------------------------------- {quote}Could we make it fail if it encounters an unknown object=C2=A0 {quote} It's not a strict calculation anyway so I don't think we should fail, esp. = since some queries (LTR) may legitimately contain arbitrary parameters - we= could simply assume a larger default value for unknown objects, equivalent= eg. to a class with a few primitive and a few moderately-sized String fiel= ds (256 bytes? 384 bytes?). > Add Accountable to Query implementations > ---------------------------------------- > > Key: LUCENE-8855 > URL: https://issues.apache.org/jira/browse/LUCENE-8855 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Andrzej Bialecki=20 > Assignee: Andrzej Bialecki=20 > Priority: Major > Attachments: LUCENE-8855.patch, LUCENE-8855.patch, LUCENE-8855.pa= tch, LUCENE-8855.patch > > > Query implementations should also support {{Accountable}}=C2=A0API in ord= er to=C2=A0monitor the memory consumption e.g. in caches where either keys = or values are {{Query}} instances. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org