From dev-return-358451-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Mon Jun 10 15:23:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 963CB180649 for ; Mon, 10 Jun 2019 17:23:06 +0200 (CEST) Received: (qmail 3459 invoked by uid 500); 10 Jun 2019 15:23:01 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 3375 invoked by uid 99); 10 Jun 2019 15:23:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jun 2019 15:23:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AEA12E2CFC for ; Mon, 10 Jun 2019 15:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 52F1F2462F for ; Mon, 10 Jun 2019 15:23:00 +0000 (UTC) Date: Mon, 10 Jun 2019 15:23:00 +0000 (UTC) From: "Uwe Schindler (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Moved] (LUCENE-8847) Code Cleanup - Performance MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8847?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler moved SOLR-13533 to LUCENE-8847: ---------------------------------------------- Security: (was: Public) Lucene Fields: New Key: LUCENE-8847 (was: SOLR-13533) Project: Lucene - Core (was: Solr) > Code Cleanup - Performance > -------------------------- > > Key: LUCENE-8847 > URL: https://issues.apache.org/jira/browse/LUCENE-8847 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Koen De Groote > Priority: Trivial > Labels: performance > > EDIT: Again, to clarify, please don't bother yourself with this ticket on= company time, on personal time you could be working on something that make= s you money or improves the product for your feature personally. > =C2=A0 > This entire ticket is an afterthough. A look back at the code base that m= ost people don't have the time for. > --------- > =C2=A0 > Code cleanup as suggested by static analysis tools. Will be done in my sp= are time. > If someone reviews this, please also do not take up actual time from your= work to do that. I do not wish to take away from your working hours. > =C2=A0 > These are simple, trivial things, that were probably overlooked or not ev= en considered(which isn't an accusation or something negative). But also st= uff that the Java compiler/JIT won't optimize on its own. > =C2=A0 > That's what static analysis tool are good for: picking stuff like that up= . > =C2=A0 > I'm talking about Intellij's static code analysis. Facebook's "Infer" for= Java. Google's "errorprone", etc... > These are the kinds of things that, frankly, for the people actually work= ing on real features, are very time consuming, not even part of the feature= , and have a very low chance of actually turning up a real performance issu= e. > So I'm opting to have a look at the results of these tools and implementi= ng the sensible stuff and if something bigger pops up I'll make a separate = ticket for those things individually. > =C2=A0 > Creating this ticket so I can name a branch after it. > =C2=A0 > The only questions I have are: since the code base is so large, do I appl= y each subject to all parts of it? Or only core? How do I split it up? > Do I make multiple PRs with this one ticket? Or do I make multiple ticket= s and give each their own PR? -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org