From dev-return-357853-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Wed Jun 5 16:10:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F30B4180763 for ; Wed, 5 Jun 2019 18:10:05 +0200 (CEST) Received: (qmail 11926 invoked by uid 500); 5 Jun 2019 16:10:01 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 11908 invoked by uid 99); 5 Jun 2019 16:10:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jun 2019 16:10:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7F6D7E002F for ; Wed, 5 Jun 2019 16:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F15724599 for ; Wed, 5 Jun 2019 16:10:00 +0000 (UTC) Date: Wed, 5 Jun 2019 16:10:00 +0000 (UTC) From: "Erick Erickson (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-13507?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1685= 6818#comment-16856818 ]=20 Erick Erickson edited comment on SOLR-13507 at 6/5/19 4:09 PM: --------------------------------------------------------------- We=C2=A0 should probably also add comments to the code to warn devs in futu= re against adding "addr" back in, or specifying {code}"*"{code}. NOTE: curr= ently SolrTestCaseJ4 sets this property to "*". I was "iffy" about that. Attached a=C2=A0 straw-man patch, could you take it from here? Haven't even= tried to compile,=C2=A0 but it was faster than explaining ;) was (Author: erickerickson): We=C2=A0 should probably also add comments to the code to warn devs in futu= re against adding "addr" back in, or specifying "*". NOTE: currently SolrTe= stCaseJ4 sets this property to "*". I was "iffy" about that. Attached a=C2=A0 straw-man patch, could you take it from here? Haven't even= tried to compile,=C2=A0 but it was faster than explaining ;) > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endp= oint. > -------------------------------------------------------------------------= ----- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public)=20 > Reporter: Anshum Gupta > Assignee: Anshum Gupta > Priority: Major > Attachments: SOLR-13507.patch > > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org