From dev-return-358174-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Fri Jun 7 18:41:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7221818067E for ; Fri, 7 Jun 2019 20:41:03 +0200 (CEST) Received: (qmail 71032 invoked by uid 500); 7 Jun 2019 18:41:01 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 70946 invoked by uid 99); 7 Jun 2019 18:41:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Jun 2019 18:41:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 74253E2D05 for ; Fri, 7 Jun 2019 18:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2BFDA2462F for ; Fri, 7 Jun 2019 18:41:00 +0000 (UTC) Date: Fri, 7 Jun 2019 18:41:00 +0000 (UTC) From: "Namgyu Kim (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8817) Combine Nori and Kuromoji DictionaryBuilder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8817?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 58895#comment-16858895 ]=20 Namgyu Kim commented on LUCENE-8817: ------------------------------------ I share the current status. The merge is almost over and I need some discussion. =C2=A0 I thought several structures. 1. Save in tools of analysis-common module. It is simple, but I think MeCab is difficult to see as a feature of analys= is-common. 2. Create tools folder in analysis and set mecab-tools module in there. analysis/tools =E2=94=80 analysis-common-tools (to-be) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =E2=94=94 icu-tools (to-be) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =E2=94=94 mecab-tools =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =E2=94=94 ... The problem with this is that the number of modules increases a lot becaus= e each tool is created as a module. 3. Create a module called mecab we can create a mecab module that is the starting point for merging nori a= nd kuromoji. If we proceed in this direction, we will only have tools in src. But this approach may not be easy to create the runnable jar. Because it will include the library. (ex: MecabAnalyzer, MecabTokenizer, ...) 4. Create a module called mecab-tools It's easy to develop, but there are other library modules in analysis. So something seems strange because it's only runnable-jar. =C2=A0 Number 2 seems to be the best, but I'm not sure yet. I would appreciate any comments. =C2=A0 I will go ahead if direction is set, but landing will be delayed a little. The reason is that the build system is going to change. (SOLR-13452) But if it does not matter, I will proceed. > Combine Nori and Kuromoji DictionaryBuilder > ------------------------------------------- > > Key: LUCENE-8817 > URL: https://issues.apache.org/jira/browse/LUCENE-8817 > Project: Lucene - Core > Issue Type: New Feature > Reporter: Namgyu Kim > Priority: Major > > This issue is related to LUCENE-8816. > Currently Nori and Kuromoji Analyzer use the same dictionary structure. (= MeCab) > If we make combine DictionaryBuilder, we can reduce the code size. > But this task may have a dependency on the language. > (like HEADER string in BinaryDictionary and CharacterDefinition, methods= in BinaryDictionaryWriter, ...) > On the other hand, there are many overlapped classes. > The purpose of this patch is to provide users of Nori and Kuromoji with t= he same system dictionary generator. > It may take some time because there is a little workload. > The work will be based on the latest master, and if the LUCENE-8816 is f= inished first,=C2=A0I will pull the latest code and proceed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org