From dev-return-357389-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Sat Jun 1 17:03:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9EBC818061A for ; Sat, 1 Jun 2019 19:03:03 +0200 (CEST) Received: (qmail 21903 invoked by uid 500); 1 Jun 2019 17:03:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 21892 invoked by uid 99); 1 Jun 2019 17:03:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Jun 2019 17:03:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 71A4EE0101 for ; Sat, 1 Jun 2019 17:03:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E91172459A for ; Sat, 1 Jun 2019 17:03:00 +0000 (UTC) Date: Sat, 1 Jun 2019 17:03:00 +0000 (UTC) From: "Mark Miller (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-13452) Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-13452?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1685= 3762#comment-16853762 ]=20 Mark Miller commented on SOLR-13452: ------------------------------------ {quote}as long as something unexpected will fail precommit, probably due to= a missing checksum. {quote} There are a variety of checks and enforcers that would fire and alert of yo= u all the changes going on - you would then have to accept and commit those= changes. For example, let's say you update a single version of a library and it adds= a couple of dependencies and changes the versions of a couple others. * The license check would fail for new dependencies. * The jar checksum check would fail for new dependencies and for version ch= anges. * The versions plugin would fail the check target until you do gradlew --wr= ite-locks and review/accept an updated versions.locks file that lists every= dependency and it's current version. IMO, the best idea is to let gradle handle transitive deps and version reso= lution - it will do the best job. A human then reviews and either accepts o= r makes constraints / exceptions. The whole system is designed to work this= way really, and when done right, it's really the best we have IMHO. bq. Does the precommit check notice when there's a checksum but no matching= jar? This is a little more complicated than that to do well or thoroughly. There= is a cool plugin that helps with this, but it doesn't work with implementa= tion and api yet. When it does, we can use it to find deps that are not act= ually used by anything anymore. > Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle. > ------------------------------------------------------------------------- > > Key: SOLR-13452 > URL: https://issues.apache.org/jira/browse/SOLR-13452 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public)=20 > Components: Build > Reporter: Mark Miller > Assignee: Mark Miller > Priority: Major > Fix For: master (9.0) > > > I took some things from the great work that Dat did in [https://github.co= m/apache/lucene-solr/tree/jira/gradle] and took the ball a little further. > =C2=A0 > When working with gradle in sub modules directly, I recommend=C2=A0[https= ://github.com/dougborg/gdub] > This gradle branch uses the following plugin for version locking, version= configuration and version consistency across modules: [https://github.com/= palantir/gradle-consistent-versions] > =C2=A0 > =C2=A0https://github.com/apache/lucene-solr/tree/jira/SOLR-13452_gradle_2 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org