From dev-return-357421-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Sun Jun 2 01:30:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0349B18061A for ; Sun, 2 Jun 2019 03:30:03 +0200 (CEST) Received: (qmail 63769 invoked by uid 500); 2 Jun 2019 01:30:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 63756 invoked by uid 99); 2 Jun 2019 01:30:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Jun 2019 01:30:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65A5DE00A5 for ; Sun, 2 Jun 2019 01:30:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E285320FEB for ; Sun, 2 Jun 2019 01:30:00 +0000 (UTC) Date: Sun, 2 Jun 2019 01:30:00 +0000 (UTC) From: "Noble Paul (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-13347) Error writing Transaction log for UUIDField MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-13347?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1685= 3856#comment-16853856 ]=20 Noble Paul commented on SOLR-13347: ----------------------------------- I would like to know if the patch I just submitted fix the problem. If it d= oes not , we will see investigate this further. Let me explain why adding new types is a problem JavabinCodec is a public format using which users can send data to Solr. Wh= ereas=C2=A0TransactionLog is something Solr internally uses. When we add a = new type to JavabinCodec, * it is a backward incompatible change. (new clients can't talk to old Sol= r )=C2=A0 * It also creates problems with compatibility with other formats. i.e. I c= ans send a UUID using native format using javabin, but when I'm using json/= XML it has to use String. This requires special handling in Solr to handle = data that is coming in as native object vs. String. So, we are introducing = special cases everywhere I'm OK with having a new type if it is limited to TransactionLog because it= is used internally only. We can do whatever we want . =C2=A0 > Error writing Transaction log for UUIDField > ------------------------------------------- > > Key: SOLR-13347 > URL: https://issues.apache.org/jira/browse/SOLR-13347 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public)=20 > Components: Server > Affects Versions: 7.7, 7.7.1, 8.0 > Reporter: Thomas W=C3=B6ckinger > Priority: Major > Labels: pull-request-available, ready-to-commit, test > Attachments: SOLR-13347.patch > > Time Spent: 2.5h > Remaining Estimate: 0h > > When using Atomic Update, adding a value leads to following Exception > org.apache.solr.common.SolrException: TransactionLog doesn't know how to = serialize class java.util.UUID; try implementing ObjectResolver? > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.TransactionLog$1.resolve(Tra= nsactionLog.java:100) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.writeVal(J= avaBinCodec.java:263) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.writeArray= (JavaBinCodec.java:770) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.writeKnown= Type(JavaBinCodec.java:369) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.writeKnown= Type(JavaBinCodec.java:362) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.writeVal(J= avaBinCodec.java:252) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec$BinEntryWr= iter.put(JavaBinCodec.java:437) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.MapWriter$EntryWriter.putNoE= x(MapWriter.java:100) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.MapWriter$EntryWriter.lambda= $getBiConsumer$0(MapWriter.java:160) > =C2=A0=C2=A0 =C2=A0at java.base/java.util.LinkedHashMap.forEach(LinkedHas= hMap.java:684) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.SolrInputDocument.writeMap(S= olrInputDocument.java:51) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.writeSolrI= nputDocument(JavaBinCodec.java:657) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.TransactionLog.write(Transac= tionLog.java:371) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.UpdateLog.add(UpdateLog.java= :573) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.UpdateLog.add(UpdateLog.java= :552) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.DirectUpdateHandler2.doNorma= lUpdate(DirectUpdateHandler2.java:351) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.DirectUpdateHandler2.addDoc0= (DirectUpdateHandler2.java:289) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.DirectUpdateHandler2.addDoc(= DirectUpdateHandler2.java:236) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.processor.RunUpdateProcessor= .processAdd(RunUpdateProcessorFactory.java:76) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.processor.UpdateRequestProce= ssor.processAdd(UpdateRequestProcessor.java:55) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.processor.DistributedUpdateP= rocessor.doLocalAdd(DistributedUpdateProcessor.java:995) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.processor.DistributedUpdateP= rocessor.versionAdd(DistributedUpdateProcessor.java:1216) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.processor.DistributedUpdateP= rocessor.processAdd(DistributedUpdateProcessor.java:700) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.update.processor.LogUpdateProcessor= Factory$LogUpdateProcessor.processAdd(LogUpdateProcessorFactory.java:103) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.handler.loader.JavabinLoader$1.upda= te(JavabinLoader.java:110) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.client.solrj.request.JavaBinUpdateR= equestCodec$StreamingCodec.readOuterMostDocIterator(JavaBinUpdateRequestCod= ec.java:327) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.client.solrj.request.JavaBinUpdateR= equestCodec$StreamingCodec.readIterator(JavaBinUpdateRequestCodec.java:280) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.readObject= (JavaBinCodec.java:335) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.readVal(Ja= vaBinCodec.java:280) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.client.solrj.request.JavaBinUpdateR= equestCodec$StreamingCodec.readNamedList(JavaBinUpdateRequestCodec.java:235= ) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.readObject= (JavaBinCodec.java:300) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.readVal(Ja= vaBinCodec.java:280) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.common.util.JavaBinCodec.unmarshal(= JavaBinCodec.java:193) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.client.solrj.request.JavaBinUpdateR= equestCodec.unmarshal(JavaBinUpdateRequestCodec.java:126) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.handler.loader.JavabinLoader.parseA= ndLoadDocs(JavabinLoader.java:123) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.handler.loader.JavabinLoader.load(J= avabinLoader.java:70) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.handler.UpdateRequestHandler$1.load= (UpdateRequestHandler.java:97) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.handler.ContentStreamHandlerBase.ha= ndleRequestBody(ContentStreamHandlerBase.java:68) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.handler.RequestHandlerBase.handleRe= quest(RequestHandlerBase.java:199) > =C2=A0=C2=A0 =C2=A0at org.apache.solr.core.SolrCore.execute(SolrCore.java= :2559) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org