From dev-return-358942-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Thu Jun 13 11:08:39 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A2FF518064E for ; Thu, 13 Jun 2019 13:08:39 +0200 (CEST) Received: (qmail 60008 invoked by uid 500); 13 Jun 2019 11:08:37 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 59996 invoked by uid 99); 13 Jun 2019 11:08:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2019 11:08:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A3FC71A45BC for ; Thu, 13 Jun 2019 11:08:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.003 X-Spam-Level: ** X-Spam-Status: No, score=2.003 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cominvent-com.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id fOBZMvfWlVpx for ; Thu, 13 Jun 2019 11:08:34 +0000 (UTC) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1ED445F382 for ; Thu, 13 Jun 2019 11:08:34 +0000 (UTC) Received: by mail-lj1-f169.google.com with SMTP id r9so1007567ljg.5 for ; Thu, 13 Jun 2019 04:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cominvent-com.20150623.gappssmtp.com; s=20150623; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=2KMYQHz8ozvGm/dx32Vx6zDCJgWqKIFzsPci00+64sQ=; b=Et+0QjJyBKzv3mKJ+MI3kQbxJCxNrSrFgUtZHxNfG3bIF15yV4GKxx8QWhvEYWBdDe 3Q+mSPD0DPynadyqNlkoNiweyocDs/Xajh/pVIailrS3qu3iAxq1j5yWcZcWLfG31Xw3 3HoPJat9qS//25YjoD56uswehJdYkEN/CHV+BPiyF+RRsO3qHzKelNsUG8Tqn5r8uGxj OgotLOdoJBgFq9SWQwtpzlw6I/Pm0ns3BwZoiJjbzusoDBcEWv2n0ht52859WylYHqWt s5YB+knhguXEVg1HYSUUm7dht4ygtbBh+M6dsj7pi2M42c4FT1LDInRtiOd2AKNoEAvs rWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=2KMYQHz8ozvGm/dx32Vx6zDCJgWqKIFzsPci00+64sQ=; b=A4gVPg6ziMIhA7EmGRJWgmAvhFTj0H9HNUjdsjG5NeIEez0XB2xmV2pIKS5QyzAiP7 qGBUooF8Ny2Hwd4uhkLrAGEdmDnoCjMFLV7RCG09+iPKzzVFjmKwwhrqdcTk+7qVSQ+p tay4gcrKzo1JuNN/Hbd6bJxxxkMz+DA+vDDEO3y7XqAFpdq5osF2fYC2Ofv8tZzYuoLD X9PWnRQOvDaS2LbABHne/Q/x65LqAeYxGJIowdE21QwO9jfee65CaysajhzsYTZO3ZlK 5L8p74ILbAiuZMU186gDIGnWOITEqL83shvwme2eZ9BE5jr3c/MnDPbZSo43DOaN7EFc 9cYw== X-Gm-Message-State: APjAAAUaIpXVv8zaarRV5icSkO0AxlYZKDHtUfLKoePBIplAKG7e6dvp u9ozR22zl5C2qMioppaIq4mswvcoxE5tLg== X-Google-Smtp-Source: APXvYqxyYU5m1hboYeIA/qRXYTSAwdGIkUrH1AU0sbP20cwOiwDebQU9D0mDGRx294hRvu1uQP2QQw== X-Received: by 2002:a2e:814e:: with SMTP id t14mr15356426ljg.167.1560424113328; Thu, 13 Jun 2019 04:08:33 -0700 (PDT) Received: from [192.168.127.248] ([195.159.250.196]) by smtp.gmail.com with ESMTPSA id q7sm565391ljc.45.2019.06.13.04.08.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 04:08:32 -0700 (PDT) From: =?utf-8?Q?Jan_H=C3=B8ydahl?= Content-Type: multipart/alternative; boundary="Apple-Mail=_CD653E8C-5751-4D11-AC02-E31F07E9E254" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: Github PRs without attached JIRA issue Date: Thu, 13 Jun 2019 13:08:31 +0200 References: <00414C73-F0CE-4286-9F48-774D45E21A29@cominvent.com> <7ef81259-8ed2-4b54-b385-80a8f5fe10bf@Spark> To: dev@lucene.apache.org In-Reply-To: Message-Id: <8D2500F7-818C-4AD4-884E-DBB3F7DFADF7@cominvent.com> X-Mailer: Apple Mail (2.3445.104.11) --Apple-Mail=_CD653E8C-5751-4D11-AC02-E31F07E9E254 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Once we get C in place (Github PR template), this will hopefully fix = itself. So I propose to try PR template as a first measure and then revisit if = that is not enough. Still left to do is to triage the existing open PRs and link them. Who = wants to help?=20 = https://github.com/apache/lucene-solr/pulls?utf8=3D=E2=9C=93&q=3Dis%3Apr+i= s%3Aopen+NOT+LUCENE+in%3Atitle+AND+NOT+SOLR+in%3Atitle+=20 We should probably also look for PRs with a LUCENE/SOLR jira attached, = where the fix is merged without auto-closing PR, and then close those. TIP: When you merge code outside of github, add the text "fixes #123" to = the commit message to automatically close PR#123. -- Jan H=C3=B8ydahl, search solution architect Cominvent AS - www.cominvent.com > 10. jun. 2019 kl. 15:05 skrev Gus Heck : >=20 > Or the committer can create it if the issue is truly trivial... Also, = one of the things that folks who contribute may gain is learning about = development process. That aspect was extremely helpful to me when I made = my first contributions to Ant many years ago. Not everyone who = contributes is an expert. >=20 > On Mon, Jun 10, 2019 at 3:33 AM Varun Thacker > wrote: > I think D is important for making the barrier low for new contributors = to get started. >=20 > It won't be great as we'll have two places to look a CHANGES entry = against but I'll be okay with that. >=20 > Today a new contributor creates a PR and a committer can even merge = the PR from the github interface. But in between those 2 steps we have = to tell the contributor to go create a placeholder Jira. >=20 > Imagine if this new contributor just wants to fix one typo from the = ref guide. The overhead involved will shun quite a lot of folks? >=20 > On Sat, Jun 8, 2019 at 2:22 PM Jan H=C3=B8ydahl > wrote: > Jira has become very heavy-weight over the years and I'm not sure we = need all those features. > I think Github issues are a bit too lightweight perhaps, so I'm not = actively promoting option E, just lifting it up as a real alternative. >=20 >> As an example how would you implement the security issue visibility = with original poster and PMC able to see it in github? >=20 > Think they have something in the makings for this, see = https://github.com/apache/lucene-solr/security/policy = =20 > Have no idea if you can limit the group who sees them to PMC members = though. >=20 > -- > Jan H=C3=B8ydahl, search solution architect > Cominvent AS - www.cominvent.com >=20 >=20 >=20 > --=20 > http://www.needhamsoftware.com = (work) > http://www.the111shift.com (play) --Apple-Mail=_CD653E8C-5751-4D11-AC02-E31F07E9E254 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Once = we get C in place (Github PR template), this will hopefully fix = itself.
So I propose to try PR template as a first = measure and then revisit if that is not enough.

Still left to do is to = triage the existing open PRs and link them. Who wants to = help? 

  https://github.com/apache/lucene-solr/pulls?utf8=3D=E2=9C=93&am= p;q=3Dis%3Apr+is%3Aopen+NOT+LUCENE+in%3Atitle+AND+NOT+SOLR+in%3Atitle+=  

We = should probably also look for PRs with a LUCENE/SOLR jira attached, = where the fix is merged without auto-closing PR, and then close = those.

TIP: = When you merge code outside of github, add the text "fixes #123" to the = commit message to automatically close PR#123.

--
Jan H=C3=B8ydahl, search solution = architect
Cominvent AS - www.cominvent.com

10. jun. 2019 kl. 15:05 skrev Gus Heck <gus.heck@gmail.com>:

Or the committer can create it if the issue is truly = trivial... Also, one of the things that folks who contribute may gain is = learning about development process. That aspect was extremely helpful to = me when I made my first contributions to Ant many years ago. Not = everyone who contributes is an expert.

On Mon, Jun = 10, 2019 at 3:33 AM Varun Thacker <varun@vthacker.in> wrote:
I think D is important for making the barrier low for new = contributors to get started.

It won't be great as we'll have two = places to look a CHANGES entry against but I'll be okay with that.

Today a new contributor creates a PR and a committer can even = merge the PR from the github interface. But in between those 2 steps we = have to tell the contributor to go create a placeholder Jira.

Imagine if this new = contributor just wants to fix one typo from the ref guide. The overhead = involved will shun quite a lot of folks?

On Sat, Jun 8, 2019 at 2:22 PM Jan H=C3=B8ydahl = <jan.asf@cominvent.com> wrote:
Jira has become very = heavy-weight over the years and I'm not sure we need all those = features.
I think Github issues are a bit too lightweight = perhaps, so I'm not actively promoting option E, just lifting it up as a = real alternative.

As an example how would you = implement the security issue visibility with original poster and PMC = able to see it in github?

Think they have = something in the makings for this, see https://github.com/apache/lucene-solr/security/policy =
Have no idea if you can limit the group who sees them to PMC = members though.

--
Jan H=C3=B8ydahl, search = solution architect
Cominvent AS - www.cominvent.com

=


--
http://www.needhamsoftware.com (work)
http://www.the111shift.com (play)

= --Apple-Mail=_CD653E8C-5751-4D11-AC02-E31F07E9E254--