From dev-return-358849-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Wed Jun 12 22:16:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EF91818061A for ; Thu, 13 Jun 2019 00:16:03 +0200 (CEST) Received: (qmail 8741 invoked by uid 500); 12 Jun 2019 22:08:36 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 8471 invoked by uid 99); 12 Jun 2019 22:08:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2019 22:08:34 +0000 From: GitBox To: dev@lucene.apache.org Subject: [GitHub] [lucene-solr] jtibshirani edited a comment on issue #715: LUCENE-7714 Add a range query that takes advantage of index sorting. Message-ID: <156037730871.29242.14726064564831424417.gitbox@gitbox.apache.org> Date: Wed, 12 Jun 2019 22:08:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jtibshirani edited a comment on issue #715: LUCENE-7714 Add a range query that takes advantage of index sorting. URL: https://github.com/apache/lucene-solr/pull/715#issuecomment-501436447 Thanks @atris and @jimczi for taking a look! > However I wonder if we should expose this query as is or if we should use it only internally in the `IndexOrDocValuesQuery` ? I agree that the query is not so helpful on its own. I was unsure about integrating it into `IndexOrDocValuesQuery`, since that deals with queries generally and this query is specifically for `long` ranges. Would `IndexOrDocValuesQuery` optionally accept a third query, and only run it if the segment is sorted and also contains `NumericDocValues`? That seemed a bit specific to add to a fairly general query type. Another idea is for `IndexOrDocValuesRangeQuery` to accept a fallback range query, and delegate to it if the necessary conditions aren't met? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org