lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koen De Groote (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-8847) Code Cleanup: Remove StringBuilder.append with concatted strings
Date Mon, 10 Jun 2019 15:51:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860095#comment-16860095
] 

Koen De Groote edited comment on LUCENE-8847 at 6/10/19 3:50 PM:
-----------------------------------------------------------------

Perhaps I should clarify what I meant by "how to split".

 

Since it is expected that all merged PRs go into the CHANGES.txt file, it seems to me like
it cannot be that the same number appears more than 1 time.

Or can it? Can I mentioned SOLR-13533 multiple times?

If not, it looks like I'll have to make multiple tickets like this?

 

EDIT: Oh, I didn't see those last 2 comments while writing this, sorry about that.

Also, wasn't aware of the change since Java9


was (Author: koendg):
Perhaps I should clarify what I meant by "how to split".

 

Since it is expected that all merged PRs go into the CHANGES.txt file, it seems to me like
it cannot be that the same number appears more than 1 time.

Or can it? Can I mentioned SOLR-13533 multiple times?

If not, it looks like I'll have to make multiple tickets like this?

 

EDIT: Oh, I didn't see those last 2 comments while writing this, sorry about that.

> Code Cleanup: Remove StringBuilder.append with concatted strings
> ----------------------------------------------------------------
>
>                 Key: LUCENE-8847
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8847
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Koen De Groote
>            Assignee: Uwe Schindler
>            Priority: Trivial
>             Fix For: master (9.0)
>
>
> EDIT: Again, to clarify, please don't bother yourself with this ticket on company time,
on personal time you could be working on something that makes you money or improves the product
for your feature personally.
>  
> This entire ticket is an afterthough. A look back at the code base that most people don't
have the time for.
> ---------
>  
> Code cleanup as suggested by static analysis tools. Will be done in my spare time.
> If someone reviews this, please also do not take up actual time from your work to do
that. I do not wish to take away from your working hours.
>  
> These are simple, trivial things, that were probably overlooked or not even considered(which
isn't an accusation or something negative). But also stuff that the Java compiler/JIT won't
optimize on its own.
>  
> That's what static analysis tool are good for: picking stuff like that up.
>  
> I'm talking about Intellij's static code analysis. Facebook's "Infer" for Java. Google's
"errorprone", etc...
> These are the kinds of things that, frankly, for the people actually working on real
features, are very time consuming, not even part of the feature, and have a very low chance
of actually turning up a real performance issue.
> So I'm opting to have a look at the results of these tools and implementing the sensible
stuff and if something bigger pops up I'll make a separate ticket for those things individually.
>  
> Creating this ticket so I can name a branch after it.
>  
> The only questions I have are: since the code base is so large, do I apply each subject
to all parts of it? Or only core? How do I split it up?
> Do I make multiple PRs with this one ticket? Or do I make multiple tickets and give each
their own PR?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message