lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Sokolov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-8844) Bump FST Version
Date Sat, 08 Jun 2019 13:41:00 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-8844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mike Sokolov updated LUCENE-8844:
---------------------------------
    Description: 
In LUCENE-8781, we changed the FST encoding but did not bump the version number we write in
its header. The change was backwards-compatible (new readers can still read old FSTs), but
not forwards-compatible: older readers would exhibit strange behavior if they attempted to
read one of these newer format FSTs.

It would be much better if readers could catch such errors and notify in a sensible way, and
we have version checking that does that; we just need to increase the VERSION_CURRENT constant.

Also, ~[~dsmiley] points out the CHANGES.txt entries for LUCENE-8781 should be moved to the
8.2.0 section since that change was backported. I think we can clean that up at the same time
since it's version-related.

  was:
In LUCENE-8781, we changed the FST encoding but not bump the version number we write in its
header. The change was backwards-compatible (new readers can still read old FSTs), but not
forwards-compatible: older readers would exhibit strange behavior if they attempted to read
one of these newer format FSTs.

It would be much better if readers could catch such errors and notify in a sensible way, and
we have version checking that does that; we just need to increase the VERSION_CURRENT constant.

Also, ~[~dsmiley] points out the CHANGES.txt entries for LUCENE-8781 should be moved to the
8.2.0 section since that change was backported. I think we can clean that up at the same time
since it's version-related.


> Bump FST Version
> ----------------
>
>                 Key: LUCENE-8844
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8844
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Mike Sokolov
>            Assignee: Mike Sokolov
>            Priority: Major
>
> In LUCENE-8781, we changed the FST encoding but did not bump the version number we write
in its header. The change was backwards-compatible (new readers can still read old FSTs),
but not forwards-compatible: older readers would exhibit strange behavior if they attempted
to read one of these newer format FSTs.
> It would be much better if readers could catch such errors and notify in a sensible way,
and we have version checking that does that; we just need to increase the VERSION_CURRENT
constant.
> Also, ~[~dsmiley] points out the CHANGES.txt entries for LUCENE-8781 should be moved
to the 8.2.0 section since that change was backported. I think we can clean that up at the
same time since it's version-related.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message